This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Add expectation value measurement error mitigation #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tigation * Allow non-Z diagonal expval operators. * Add function for returning mitigation overhead * Add function for returning std-dev upper bound of estimation * Add function for returning required shots for mitigation accuracy
Co-Authored-By: George S. Barron <[email protected]>
Base class functions that compute properties from A-matrix still need to be overloaded to be computed more efficiently using the rate and generator matrices.
Due to Numba not really working well with Numpy random I had to pregenerate a large array of random samples outside of the compiled Numba functions in advance.
mtreinish
reviewed
Sep 18, 2020
There was a problem hiding this comment.
Can you add numba as an extra requirement here: https://github.com/Qiskit/qiskit-ignis/blob/master/setup.py#L79-L82 just add a new dict entry where the key is the name and the value is a list of the requirements. So in this case something like 'expval-measurement': ['numba'] it's also probably worth updating the readme section here: https://github.com/Qiskit/qiskit-ignis/blob/master/README.md#extra-requirements after you add it.
|
I'm trying to understand the functionality by reading the example notebook. Could you please update the notebook to work with this code? |
yaelbh
reviewed
Sep 21, 2020
|
I'll try to use the tests as usage examples |
|
I see now the functions in |
yaelbh
suggested changes
Sep 21, 2020
| self._noise_strengths[qubits] = gamma | ||
| return self._noise_strengths[qubits] | ||
|
|
||
| def seed(self, value=None): |
There was a problem hiding this comment.
Not sure that this is the correct location for this function
There was a problem hiding this comment.
This is how seeds are changed on persistent objects in the quantum info module, but i added an option to set fixed seed at init as well.
|
As far as I see, there are no usage examples (tests or notebook) for the diagonal other than the default. This is not tested. See also the comment about the diagonal being a numpy array instead of an operator. |
chriseclectic
added
the
Changelog: New Feature
8 tasks
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Nov 4, 2020
In qiskit-community#500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward.
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Nov 4, 2020
In qiskit-community#500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward. Fixes qiskit-community#532
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Nov 4, 2020
In qiskit-community#500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward. Fixes qiskit-community#532
chriseclectic
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Fix ignis without optional requirements installed In #500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward.
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Nov 12, 2020
* Fix ignis without optional requirements installed In qiskit-community#500 type hints were added for the plotting functions using the optional matplotlib dependencies. This breaks ignis installations without matplotlib present since it's an optional dependency. Since type hints are really just for documentation and not necessary this commit just removes those problematic hints and uses the docstring to document the types. At the same time the testing job verifying ignis works without any optional dependencies that was lost in the migration from travis to github actions is restored to verify that everything works moving forward. (cherry picked from commit d9fe8f9)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces #457 by adding expectation value measurement error mitigation using the current Ignis API style.
Co-authored-by: George S. Barron [email protected]
Details and comments
It includes Full A-matrix, tensored A-matrix, and CTMP mitigation methods.
For the CTMP method Numba will be used if it is installed to greatly improve performance.
TODO: